Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding statefulset to the list of things kubectl says it knows about #37031

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Adding statefulset to the list of things kubectl says it knows about #37031

merged 1 commit into from
Nov 18, 2016

Conversation

foxish
Copy link
Contributor

@foxish foxish commented Nov 17, 2016 •
edited by k8s-oncall

What this PR does / why we need it: Adding statefulset to the list of things kubectl says it knows about.

Special notes for your reviewer:

Release note:

NONE

cc @kubernetes/sig-apps @erictune

This change is Reviewable

@foxish foxish added area/kubectl release-note-none Denotes a PR that doesn't merit a release note. team/ux labels Nov 17, 2016
@foxish foxish added this to the v1.5 milestone Nov 17, 2016
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 17, 2016
@foxish foxish mentioned this pull request Nov 17, 2016
Closed
@foxish
Copy link
Contributor Author

foxish commented Nov 17, 2016

@k8s-bot unit test this

@justinsb
Copy link
Member

I think we need an abbreviation; I proposed ss in #37033 but this PR came first.

I created my PR primarily because having to type "kubectl get statefulset" was a show-stopper for me personally :-)

@krmayankk
Copy link

i was just about to say, 'ss' as abbreviation for the statefulset, any other suggestions ?

@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2016
@janetkuo
Copy link
Member

Let's not decide the abbreviation yet at this moment.

@foxish
Copy link
Contributor Author

foxish commented Nov 17, 2016

@k8s-bot kops aws e2e test this

@foxish
Copy link
Contributor Author

foxish commented Nov 17, 2016

@k8s-bot kubemark e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 4b53a32. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cae6cf2 into kubernetes:master Nov 18, 2016
@foxish foxish deleted the add-ss-kubectl branch November 18, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@janetkuo janetkuo

Labels
area/kubectl lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@foxish @justinsb @krmayankk @janetkuo @k8s-github-robot @k8s-ci-robot @googlebot